search

opencomputeproject / CADCloud

CADCloud is a cloud based sharing infrastructure dedicates to CAD engineers. It allows users to share design files, browse them interactively through a simple web interface, and support native file format from popular open source tools.
MIT License
89 stars 15 forks source link

Fix various typos/grammar #11

Open luzpaz opened 3 years ago

vejmarie commented 3 years ago

Hi @luzpaz

Thanks for your PR. My english is not as good as it should be ;). Quick question do you mind signing your commit ? You can do that through git -s --amend. You can sign through a GPG key or public / private key. We are doing this to keep track of code committers in the case we need to get in touch with them, and we would like to avoid that people steal potential identities ;) in the case your github account got hacked. That is the only one constraint that we have.

vejmarie

luzpaz commented 3 years ago

i don't have a GPG key. Can i use my ssh public key ?

vejmarie commented 3 years ago

I don't think so, You need a GPG key to sign commit. Setting it up is easy whatever the O/S you use, you can follow the guideline here

https://github.com/settings/keys .

The ssh key is used to simplify your authentication but not to sign your commit unfortunately. I was also reluctant to do it up to the time I discovered that it was pretty easy to "steal" your identity and got an "homonym" who started to push code with my nickname.

luzpaz commented 3 years ago

Then just feel free to cherrypick the commits and erase all my info.