search

opencomputeproject / CADCloud

CADCloud is a cloud based sharing infrastructure dedicates to CAD engineers. It allows users to share design files, browse them interactively through a simple web interface, and support native file format from popular open source tools.
MIT License
88 stars 15 forks source link

freecad snap improvements #26

Closed ppd closed 2 years ago

ppd commented 2 years ago

@vejmarie Hi. Thanks for maintaining the freecad snap. I have a few suggestions:

Consider using extension for desktop environment setup

As far as I can see, you're setting up all desktop related things (fonts etc.) manually in the launcher script. Consider using a snapcraft extension to provide this, simplify the snap, and profit from upstream improvements.

The gnome-3-38 extension works fine for Qt based applications (see https://github.com/ppd/anki-ppd/blob/master/snap/snapcraft.yaml for an example).

Use lzo compression

This drastically improves startup (especially cold start) times at the cost of a small size increase. That's a very good idea for snaps that do not need to support very old squashfs/kernel versions without lzo support.

Fix addon manager getting stuck at "cloning module"

See https://github.com/opencomputeproject/CADCloud/pull/25

Set up dependencies in snapcraft.yaml

As far as I can see, you're adding PPAs before launching snapcraft, and you're also building dependencies outside the snapcraft scripts. Both things could be done inside the snapcraft.yaml file, making it self-contained and independent of its build environment.

Move freecad to separate repository

To make it more discoverable for users (bug reporters) and developers.

If you're interested in (some of) those changes, I can create a few PRs.

ppd commented 2 years ago

I've decided to update my personal package and list it in the store: https://snapcraft.io/freecad-ppd Source is at https://github.com/ppd/freecad-ppd