search

opencomputeproject / HWMgmt-OCP-Profiles

A place where all the OCP profiles are a placed. Issues can be submitted/resolved and modifications can be reviewed/merged
Apache License 2.0
17 stars 17 forks source link

ServerHW profile has incorrect Compare property for UEFI #10

Closed jautor closed 5 years ago

jautor commented 5 years ago

The ConditionalRequirement for UefiTargetBootSourceOverride has a Values property which should be CompareValues as the comparison is for the value of another property, not it's own value.

jautor commented 5 years ago

Same error occurs on the IndicatorLED property.

JojoWu19 commented 5 years ago

@jautor , below parts also have similar issue in the OCPServerHardwareManagement.v0_2_3(4).json:

"SKU": {
    "ReadRequirement": "Recommended",
    "ConditionalRequirements": [{
        "Purpose": "Either PartNumber or SKU (or both) must be implemented.",
        "CompareProperty": "PartNumber",
        "Comparison": "Absent",
        "ReadRequirement": "Mandatory"
    }]
},

and

"PartNumber": {
    "ReadRequirement": "Recommended",
    "ConditionalRequirements": [{
        "Purpose": "Either PartNumber or SKU (or both) must be implemented.",
        "CompareProperty": "SKU",
        "Comparison": "Absent",
        "ReadRequirement": "Mandatory"
    }]
},

It looks like "Comparison": "Absent", should be "CompareType": "Absent", right?