opencomputeproject / HWMgmt-OCP-Profiles

A place where all the OCP profiles are a placed. Issues can be submitted/resolved and modifications can be reviewed/merged
Apache License 2.0
14 stars 14 forks source link

Fix CompareType for SKU and PartNumber properties #18

Closed liamhieuvu closed 3 years ago

liamhieuvu commented 4 years ago

OCP server hardware management requires either ComputerSystem.SKU or ComputerSystem.PartNumber (or both) to be implemented. This can be achieved by setting ReadRequirement field to Recommended, and using ConditionalRequirements to change this field to Mandatory if SKU or PartNumber does not exist.

According to Redfish Interoperability Profiles (DSP0272 v1.2.0), section 8.4.2.5 defines:

This patch changes Comparison to CompareType for SKU and PartNumber. So, SKU ReadRequirement is Mandatory if PartNumber (CompareProperty) is Absent (CompareType) and vice versa.

Signed-off-by: Hieu Vu hieutrgvu@gmail.com

liamhieuvu commented 4 years ago

This commit resolves #17.

jautor commented 4 years ago

Agreed - this is an error in the profile.