opencomputeproject / HWMgmt-OCP-Profiles

A place where all the OCP profiles are a placed. Issues can be submitted/resolved and modifications can be reviewed/merged
Apache License 2.0
13 stars 14 forks source link

MinCount validator to be present a level above or below the PropertyRequirements #32

Closed arahimanshaik closed 2 years ago

arahimanshaik commented 2 years ago

In line 297 of OCPDoorHeatExchangerHardwareManagement Profile, MinCount Validator to be Present a level above or below the PropertyRequirements as per Redfish Interoperability Profile Specification.

Reference: https://github.com/DMTF/Redfish-Interop-Validator/issues/129

jcleung5549 commented 2 years ago

The MinCount property (297) cannot be within the PropertyRequirements property. It should be place between 290 and 291, to specify the requirement of two Temperatures array property elements.

290 "Temperatures": { 291 "PropertyRequirements": {

arahimanshaik commented 2 years ago

Hi, @mgthompson @jcleung5549 can this be resolved quickly?

jcleung5549 commented 2 years ago

If you are in a rush, feel free to create a pull request. I don't know when Michael will get to this.

mgthompson commented 2 years ago

I created two pull requests with the fixes.

On Thu, Jan 6, 2022 at 11:43 AM John Leung @.***> wrote:

If you are in a rush, feel free to create a pull request. I don't know when Michael will get to this.

— Reply to this email directly, view it on GitHub https://github.com/opencomputeproject/HWMgmt-OCP-Profiles/issues/32#issuecomment-1006737951, or unsubscribe https://github.com/notifications/unsubscribe-auth/ABAVIHTPSYT5UWTQ7EZLHFDUUXBE7ANCNFSM5JWYXO6Q . Triage notifications on the go with GitHub Mobile for iOS https://apps.apple.com/app/apple-store/id1477376905?ct=notification-email&mt=8&pt=524675 or Android https://play.google.com/store/apps/details?id=com.github.android&referrer=utm_campaign%3Dnotification-email%26utm_medium%3Demail%26utm_source%3Dgithub.

You are receiving this because you were mentioned.Message ID: @.***>

-- Michael Thompson

jcleung5549 commented 2 years ago

Fixed in #36