search

opencomputeproject / HWMgmt-OCP-Profiles

A place where all the OCP profiles are a placed. Issues can be submitted/resolved and modifications can be reviewed/merged
Apache License 2.0
13 stars 14 forks source link

Typo in physical context comparison for OCPServerHardwareManagement.v1_0_1.json #62

Open plmanik opened 6 months ago

plmanik commented 6 months ago

Hi, Physical context can be one value only, but comparison used is Allof as shown below

"Thermal": {
            "MinVersion": "1.1.0",
            "PropertyRequirements": {
                "Temperatures": {
                    "ReadRequirement": "Mandatory",
                    "MinCount": 3,
                    "PropertyRequirements": {
                        "ReadingCelsius": {},
                        "PhysicalContext": {
                            **"Comparison": "AllOf",**
                            "Values": ["CPU", "Intake", "SystemBoard"]
                        },

Eventhough value is coming as intake, due to Allof Comparison, it's failing please confirmw whether it needs to be Anyof or Allof

Comparison.Thermal.Temperatures.PhysicalContext | AllOf | ['CPU', 'Intake', 'SystemBoard'] | ['Intake', 'Intake', 'Intake', 'Intake', 'Intake', 'Intake', 'Intake'] | FAIL

Thanks, Mani

plmanik commented 4 months ago

@jcleung5549 Do we have any plan to fix this or any update on this?

jcleung5549 commented 3 months ago

The requirement is that there be an element in the Temperature's array with each PhysicalContext (CPU, Inlet, System). There error message indicators that all 6 elements of the array have the same PhysicalContext, "Inlet".