search

opencomputeproject / HWMgmt-OCP-Profiles

A place where all the OCP profiles are a placed. Issues can be submitted/resolved and modifications can be reviewed/merged
Apache License 2.0
13 stars 14 forks source link

CDU management profile and specification #67

Open mraineri opened 5 months ago

mraineri commented 5 months ago

Proposal for Redfish requirements for a CDU.

Still need to provide a Markdown file for a specification that describes this in text.

mick-jones-vertiv commented 4 months ago

I expect a new baseline for Cooling Equipment to exist at some point which will be inherited by this. Refer to column D in this: https://docs.google.com/spreadsheets/d/1XP0wLm1oMLiDfpaf5FXuIATc3lkqokq9Gr05OYNDSEE/edit#gid=0

mraineri commented 3 months ago

I expect a new baseline for Cooling Equipment to exist at some point which will be inherited by this. Refer to column D in this: https://docs.google.com/spreadsheets/d/1XP0wLm1oMLiDfpaf5FXuIATc3lkqokq9Gr05OYNDSEE/edit#gid=0

Do you specifically mean that you want to break down the profiles a bit to maximize reuse? So, have one common cooling baseline, and then have the CDU profile inherit from that?

mick-jones-vertiv commented 3 months ago

Yes:

  1. Infra baseline – differs from server baseline
  2. CDU profile (and others at this level); inherits “infra baseline”

From: Mike Raineri @.> Sent: Friday, March 22, 2024 1:39 AM To: opencomputeproject/HWMgmt-OCP-Profiles @.> Cc: Jones, Mick Bruce @.>; Comment @.> Subject: Re: [opencomputeproject/HWMgmt-OCP-Profiles] CDU management profile and specification (PR #67)

CAUTION: This email originated from outside of Vertiv. Do not click links or open attachments unless you recognize the sender and know the content is safe.

I expect a new baseline for Cooling Equipment to exist at some point which will be inherited by this. Refer to column D in this: https://docs.google.com/spreadsheets/d/1XP0wLm1oMLiDfpaf5FXuIATc3lkqokq9Gr05OYNDSEE/edit#gid=0https://urldefense.com/v3/__https:/docs.google.com/spreadsheets/d/1XP0wLm1oMLiDfpaf5FXuIATc3lkqokq9Gr05OYNDSEE/edit*gid=0__;Iw!!C8PT2x6w!rzNnhCHfI8TjFpeDJhp4S3D7TZMiG6Fx0oqzvc2zEEwZE2mL5XujjMVwFEugxaoZu2jfD3cZgwN0J2bAn8wlt_sexGpckA$

Do you specifically mean that you want to break down the profiles a bit to maximize reuse? So, have one common cooling baseline, and then have the CDU profile inherit from that?

— Reply to this email directly, view it on GitHubhttps://urldefense.com/v3/__https:/github.com/opencomputeproject/HWMgmt-OCP-Profiles/pull/67*issuecomment-2012474232__;Iw!!C8PT2x6w!rzNnhCHfI8TjFpeDJhp4S3D7TZMiG6Fx0oqzvc2zEEwZE2mL5XujjMVwFEugxaoZu2jfD3cZgwN0J2bAn8wlt_usMtQJxQ$, or unsubscribehttps://urldefense.com/v3/__https:/github.com/notifications/unsubscribe-auth/ATFDC53FNPREDK43MOSR3KLYZLWJDAVCNFSM6AAAAABDEYNCUOVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDAMJSGQ3TIMRTGI__;!!C8PT2x6w!rzNnhCHfI8TjFpeDJhp4S3D7TZMiG6Fx0oqzvc2zEEwZE2mL5XujjMVwFEugxaoZu2jfD3cZgwN0J2bAn8wlt_uWsfXr3w$. You are receiving this because you commented.Message ID: @.***>

CONFIDENTIALITY NOTICE: This e-mail and any files transmitted with it are intended solely for the use of the individual or entity to whom they are addressed and may contain confidential and privileged information protected by law. If you received this e-mail in error, any review, use, dissemination, distribution, or copying of the e-mail is strictly prohibited. Please notify the sender immediately by return e-mail and delete all copies from your system.

mraineri commented 3 months ago

For "Infra Baseline", would it be restricted to "cooling infra"? I think supporting power infra in a common infra baseline would be difficult.

mick-jones-vertiv commented 3 months ago

Yeah that’s the scope. I misspoke and it should be ‘cooling infra’.

Get Outlook for iOShttps://aka.ms/o0ukef

From: Mike Raineri @.> Sent: Saturday, March 23, 2024 12:15:11 AM To: opencomputeproject/HWMgmt-OCP-Profiles @.> Cc: Jones, Mick Bruce @.>; Comment @.> Subject: Re: [opencomputeproject/HWMgmt-OCP-Profiles] CDU management profile and specification (PR #67)

CAUTION: This email originated from outside of Vertiv. Do not click links or open attachments unless you recognize the sender and know the content is safe.

For "Infra Baseline", would it be restricted to "cooling infra"? I think supporting power infra in a common infra baseline would be difficult.

— Reply to this email directly, view it on GitHubhttps://urldefense.com/v3/__https://github.com/opencomputeproject/HWMgmt-OCP-Profiles/pull/67*issuecomment-2015078880__;Iw!!C8PT2x6w!ur_53Shaps0XxqjeKRnHkJNcdAaOJoE_xOT5MWTEWM5YKsRZ6KkRfppo8SA64V90cyY4ZkMYU7EEfNc37F_OnSJ_i9IZ5w$, or unsubscribehttps://urldefense.com/v3/__https://github.com/notifications/unsubscribe-auth/ATFDC52OQGX2OTPWWAFTAQ3YZQVF7AVCNFSM6AAAAABDEYNCUOVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDAMJVGA3TQOBYGA__;!!C8PT2x6w!ur_53Shaps0XxqjeKRnHkJNcdAaOJoE_xOT5MWTEWM5YKsRZ6KkRfppo8SA64V90cyY4ZkMYU7EEfNc37F_OnSL8Dm1E9g$. You are receiving this because you commented.Message ID: @.***>

CONFIDENTIALITY NOTICE: This e-mail and any files transmitted with it are intended solely for the use of the individual or entity to whom they are addressed and may contain confidential and privileged information protected by law. If you received this e-mail in error, any review, use, dissemination, distribution, or copying of the e-mail is strictly prohibited. Please notify the sender immediately by return e-mail and delete all copies from your system.

mick-jones-vertiv commented 3 months ago

Hi Mike, I did a PR against your fork/branch which contains changes from review with OCP HMLC community for the CDU profile. We can run this revised profile against our revised public-cooling-unit mockup cleanly.

If it makes it easier I have attached the changed file here as it may be easier to do a diff locally and push to your fork instead of trying to resolve changes from my PR.

OCPCoolantDistributionUnitManagement.v0_9_0.json

mick-jones-vertiv commented 1 month ago

In LiquidCooling\OCPLiquidCoolingBaseline.v0_9_0.json the substitution variable {CoolingUnitType} does not work in Interop Validator because the regex is looking for an entry ending with "Id". I've fixed this by replacing all occurrences of CoolingUnitType with CoolingUnitTypeId in this profile.

mraineri commented 4 weeks ago

In LiquidCooling\OCPLiquidCoolingBaseline.v0_9_0.json the substitution variable {CoolingUnitType} does not work in Interop Validator because the regex is looking for an entry ending with "Id". I've fixed this by replacing all occurrences of CoolingUnitType with CoolingUnitTypeId in this profile.

Got it; changed it. We might want to see if this is something we should push into the interop validator to better handle.