search

opencomputeproject / HWMgmt-OCP-Profiles

A place where all the OCP profiles are a placed. Issues can be submitted/resolved and modifications can be reviewed/merged
Apache License 2.0
16 stars 17 forks source link

UseCaseTitle typo, chassistype enumeration values to add #69

Open plmanik opened 8 months ago

plmanik commented 8 months ago

Hi, We are seeing three issues based on https://github.com/opencomputeproject/HWMgmt-OCP-Profiles/blob/master/HWMgmt/OCPBaselineHardwareManagement.v1_1_0.json

Issue 1 UseCase.The_primary_Chassis_requirements..ReadRequirement | Mandatory | Must Exist | DNE | FAIL |

Able to see .. before ReadRequirement and it's coming due to "UseCaseTitle": "The primary Chassis requirements.", definition in profile. Is this going to fix in profile or in Redfish-Interop-Validator? If we remove . from "UseCaseTitle": "The primary Chassis requirements" failure is not coming

Issue 2 UseCase.The_Manager_providing_Redfish_service..ReadRequirement | Mandatory | Must Exist | DNE | FAIL Able to see .. before ReadRequirement and it's coming due to "UseCaseTitle": "The Manager providing Redfish service.", definition in profile. Is this going to fix in profile or in Redfish-Interop-Validator? If we remove . from "UseCaseTitle": "The Manager providing Redfish service" failure is not coming

Issue 3 "UseCaseKeyProperty": "ChassisType", "UseCaseComparison": "Equal", "UseCaseKeyValues": ["Drawer", "RackMount", "Sled"], As per schema we have other values also applicable like below, can we add above all values in UseCaseKeyValues "ChassisType": { "enum": [ "Rack", "Blade", "Enclosure", "StandAlone", "RackMount", "Card", "Cartridge", "Row", "Pod", "Expansion", "Sidecar", "Zone", "Sled", "Shelf", "Drawer", "Module", "Component", "IPBasedDrive", "RackGroup", "StorageEnclosure", "ImmersionTank", "HeatExchanger", "PowerStrip", "Other" ],

Thanks, Mani

jcleung5549 commented 7 months ago

The issues 1 and 2 should be fixed in PR #70.

jcleung5549 commented 7 months ago

Regarding issue 3, the enumeration is to align with the ChassisType's specified in the Server profile. Adding the entire enumeration who obviate the need to have the UseCase semantic. Is there a specific ChassisType value you are having problems testing?

plmanik commented 7 months ago

@jcleung5549 We are using StandAlone, Other enum values