search

opencomputeproject / HWMgmt-OCP-Profiles

A place where all the OCP profiles are a placed. Issues can be submitted/resolved and modifications can be reviewed/merged
Apache License 2.0
14 stars 16 forks source link

Support new ThermalSubsystem, PowerSubsystem, Fan, PowerSupply for OCP Server Profile #74

Open AmyChang-yh opened 5 months ago

AmyChang-yh commented 5 months ago

Same reason as https://github.com/opencomputeproject/HWMgmt-OCP-Profiles/issues/25.

Redfish in 2020.4 added PowerSubsystem, ThermalSubsystem, Fan, PowerSupply, PowerSupplyMetrics https://www.dmtf.org/sites/default/files/Redfish_Release_2020.4_Overview.pdf

25 can fix the issue on Baseline Profile, could we apply the change to Server Profile as well?

jcleung5549 commented 5 months ago

That can be done upon request of the Server Project, since the Server Profile references the Baseline Profile. The Server Project specifies to which profile an implement needs to conform.

See the Profile Release Process

AmyChang-yh commented 3 months ago

I tried to modify the parameter of OCPBaselineHardwareManagement MinVersion to 1.1.0 in OCPServerHardwareManagement.v1_1_0.json, but the Power and Thermal errors still exist by running Redfish-Interop-Validator.

ERROR - 1 fail.Comparison.Thermal.Temperatures.PhysicalContext errors in Service Level Requirements
ERROR - 1 fail.Power.ReadRequirement errors in Service Level Requirements
ERROR - 1 fail.Thermal.ReadRequirement errors in Service Level Requirements

I'm sure the Redfish-Interop-Validator had included the correct profiles because I could see the messages below.

Profile Hashes:
INFO - profile: OCPServerHardwareManagement 1.1.0, dict md5 hash: ee7fd33a778ce096020059f0dad4a15e
INFO - profile: OCPBaselineHardwareManagement 1.1.0, dict md5 hash: 94ebe02b495cecb5798a5df97b269ea6

It seems a few changes are needed for Server Profile as well.

jcleung5549 commented 3 months ago

Thank you for testing this draft profile. We will look into it.