opencomputeproject / OSF-OSFCI

Open Source Firmware Continuous Integration source code
MIT License
22 stars 11 forks source link

Dropdown Security Fix #82

Closed vedicpanda closed 1 year ago

vedicpanda commented 1 year ago

Created a security fix that prevents individuals from accessing the drop down without logging in first. Still needs to be tested

Procedure to test:

1) Open the CI page. Do not log in 2) Open up developer tools. Go to console and type in this command: $('#navbarDropdownMenuLink').removeAttr("style");, nothing should happen 3) Open up the source code, and search for navbarDropdownMenuLink. All code within the <li class="nav-item dropdown ml-md-auto" id="dropdownMaster"> should be commented out. I commented it out instead of deleted it for comparison purposes but in the final version, these comments should deleted from the source all together.

Procedure to make sure drop down actually shows up:

1) Log in. The dropdown should now appear.