search

opencomputeproject / Project-Zipline

Defines a lossless compressed data format that is independent of CPU type, operating system, file system, and character set, and is suitable for compression using the XP10 algorithm.
Other
281 stars 47 forks source link

Doubts regarding to KME test-cases #12

Closed ShraddhaDevaiya closed 4 years ago

ShraddhaDevaiya commented 4 years ago

Hello, In CCEIP and CDDIP test-cases are somewhat satisfying according to specifications and we can see or make some conclusion from the waveforms. But in KME, as we know , it is mentioned in the RTL or verilog code that, whoever use this code they have to add their own AES ans SHA definitions. So, it is absent in this verilog code, then in this Key management engine what are this given test-cases verifying? Because it is not generating any key of AES and SHA , then in test-cases what are we verifying? Even in input means in kme_ib_tdata signal TLV format is not properly given , means input MEGA TLV is also not correct. So, I couldn't understand what these test-cases are doing? Can you please put some light on it?

michaelgmcintyre commented 4 years ago

Hi Shraddha,

Test-cases are left in for completeness. During our verification, keys were generated and tested; however, for Zipline release it was not included as you've noted. For simulation, the assumption is that a SW model of AES/SHA can be acquired or will be created. There may be publicly available SW libraries for this. For RTL, actual code would need to be generated.

Thanks

ShraddhaDevaiya commented 4 years ago

Okay, got it. So if we want to verify the KME then with our design of AES and SHA, we have to develop the test-cases for key(AES key or SHA key) checking, because it is not included in this test-cases. Thanks for helping.