Closed kcudnik closed 3 months ago
@marian-pritsak please take a look
This commit will be require to update sonic-sairedis repo with this commit: https://github.com/sonic-net/sonic-sairedis/pull/1390
/azp run
NOTE: sai backward compatibility for enums is not checked in experimental directory due the dash api are changing often, we could enable backward compatibility check for specific apis/types, let me know
NOTE: sai backward compatibility for enums is not checked in experimental directory due the dash api are changing often, we could enable backward compatibility check for specific apis/types, let me know
yea, I believe this is ok. maybe some day what we need to do it to move dash outside of the experiment folder but into another folder maybe called extension
Please check in this change if there is no conflicts and approved @rlhui @lguohan
Ping
To make this binary backward compatible for extension enums, instead of starting form _ATTR_END and prevent enum shift each time new attribute is added
Update saisanitycheck to not use object type as index
Since we will move object type extensions to separate range we will need to update many shortcuts taken by saisanitycheck when it was using object type as index to fast access arrays
NOTE: this will break current logic in sonic-saireids lib and vslib oid managers, also in https://github.com/sonic-net/DASH/blob/main/dash-pipeline/SAI/src/objectidmanager.cpp, since object type with extensions will not possible to encode on a single byte. Corresponding PR fixes will be made to mitigate this issue.