search

opencomputeproject / SAI

Switch Abstraction Interface
Other
480 stars 475 forks source link

Release notes for SAI 1.14.0 #2034

Closed prasanna228 closed 2 months ago

prasanna228 commented 4 months ago

Release notes for SAI 1.14.0 release

kcudnik commented 4 months ago

Commit must be signed to pass DCO

prasanna228 commented 4 months ago

Commit must be signed to pass DCO

@kcudnik : We tried to sign off the commit, however the sign is not happening due to which we see the DCO error in PR. Can you please help us understand how to clear this DCO error ? ( We tried to sign the commit before pushing it to Github). Is there any account specific validation for SAI repo ?

rlhui commented 3 months ago

I see PR#1892, 1893, 1896, etc. also the addition but not mentioned in the release notes.

rlhui commented 3 months ago

You could use this https://github.com/opencomputeproject/SAI/compare/v1.13.3...v1.14.0 to verify

rlhui commented 3 months ago

also DCO is not yet passed

prasanna228 commented 3 months ago

1892

I see PR#1892, 1893, 1896, etc. also the addition but not mentioned in the release notes.

@rlhui We see these PRs referring Meta. Is this OK to add part of SAI release notes ?

prasanna228 commented 3 months ago

We tried to sign off the commit, however the sign is not happening due to which we see the DCO error in PR. Can you please help us understand how to clear this DCO error ? ( We tried to sign the commit before pushing it to Github). Is there any account specific validation for SAI repo ?

@rlhui We tried to sign off the commit, however the sign is not happening due to which we see the DCO error in PR. Can you please help us understand how to clear this DCO error ? ( We tried to sign the commit before pushing it to Github). Is there any account specific validation for SAI repo ?

rlhui commented 3 months ago

1892

I see PR#1892, 1893, 1896, etc. also the addition but not mentioned in the release notes.

@rlhui We see these PRs referring Meta. Is this OK to add part of SAI release notes ?

OK to add

rlhui commented 3 months ago

We tried to sign off the commit, however the sign is not happening due to which we see the DCO error in PR. Can you please help us understand how to clear this DCO error ? ( We tried to sign the commit before pushing it to Github). Is there any account specific validation for SAI repo ?

@rlhui We tried to sign off the commit, however the sign is not happening due to which we see the DCO error in PR. Can you please help us understand how to clear this DCO error ? ( We tried to sign the commit before pushing it to Github). Is there any account specific validation for SAI repo ?

Please check https://github.com/opencomputeproject/SAI/pull/2034/checks?check_run_id=26353192219

prasanna228 commented 2 months ago

We tried to sign off the commit, however the sign is not happening due to which we see the DCO error in PR. Can you please help us understand how to clear this DCO error ? ( We tried to sign the commit before pushing it to Github). Is there any account specific validation for SAI repo ?

@rlhui We tried to sign off the commit, however the sign is not happening due to which we see the DCO error in PR. Can you please help us understand how to clear this DCO error ? ( We tried to sign the commit before pushing it to Github). Is there any account specific validation for SAI repo ?

Please check https://github.com/opencomputeproject/SAI/pull/2034/checks?check_run_id=26353192219

@rlhui Since, fixing this PR for DCO errror requires rebasing the repo. It was recommended to close this PR and raise a new PR for this release notes. Hence I will close this PR and will raise a new PR for the release notes, with the comments addressed as mentioned.

prasanna228 commented 2 months ago

Since this PR has a DCO error, we are closing this and raised a new PR#2062.