search

opencomputeproject / SAI

Switch Abstraction Interface
Other
480 stars 475 forks source link

Add label attribute for Policer, RIF, Scheduler and UDF #2046

Open erohsik opened 3 months ago

erohsik commented 3 months ago

Add label attribute to a few SAI objects that will help during warmboot object matching.

kcudnik commented 3 months ago

Does this needs to be a string ? Or it would be better to make this uint32 or 64? Maybe it's discussion for sai community meeting

erohsik commented 1 month ago

Does this needs to be a string ? Or it would be better to make this uint32 or 64? Maybe it's discussion for sai community meeting

As discussed in the community meeting, the string provides the option to use the key from the application/config db entry..

rlhui commented 1 month ago

@JaiOCP , @rck-innovium , please help review? thanks.

kcudnik commented 1 month ago

Does this needs to be a string ? Or it would be better to make this uint32 or 64? Maybe it's discussion for sai community meeting

As discussed in the community meeting, the string provides the option to use the key from the application/config db entry..

what config db entry ? SAI don't have any idea about any config db entry

tjchadaga commented 1 week ago

@erohsik - could you please resolve branch conflicts?

tjchadaga commented 1 week ago

Does this needs to be a string ? Or it would be better to make this uint32 or 64? Maybe it's discussion for sai community meeting

As discussed in the community meeting, the string provides the option to use the key from the application/config db entry..

what config db entry ? SAI don't have any idea about any config db entry

@kcudnik - Since the label is populated from the application/NOS, the general consensus was that a string would be easier to manage. Is there a concern with using a string label?

kcudnik commented 1 week ago

ok, i got it now it's just a label, please resolve conflicts