Add New ioctls to R/W extended EEPROM

opencomputeproject / Time-Appliance-Project

Develop an end-to-end hypothetical reference model, network architectures, precision time tools, performance objectives and the methods to distribute, operate, monitor time synchronization within data center and much more...

MIT License

1.32k stars 101 forks source link

Add New ioctls to R/W extended EEPROM #60

Closed CharlesParent closed 2 years ago

vvfedorenko commented 2 years ago

Could you please resubmit it with correct Sign-off-by ? Another problem I can see right now is that incompatible version of user-space software could write out of bounds of user buffer. And read of course. Which is not great in terms of security. @jlemon Jonathan do you have any suggestion for this case? Maybe it's better to introduce new command code like READ_EXTENDED_EEPROM ?

jlemon commented 2 years ago

Maybe it's time just to expose the nvmem device and start deprecating the ioctls?

In the short term, a READ_EXTENDED_EEPROM command sounds reasonable.

I need to figure out why the spi-altera driver is broken for reading.

CharlesParent commented 2 years ago

Hi @vvfedorenko and @jlemon, Just signed off and update PR to add R/W ioctls extended version