search

opencomputeproject / oom

MIT License
66 stars 29 forks source link

add ethtool support and a collectd plugin #3

Closed byford closed 8 years ago

byford commented 8 years ago

Hi Don,

Here are some changes to add a ethtool "shim" and a python collectd plugin. It all seems to work. I'll attach screenshot of grafana in action. It's not meant to be pretty, just evidence that it works.

oom-grafana

donboll commented 8 years ago

2AM? Wow! I’ll start chewing through this. Thanks!

Don

From: Dustin Byford [mailto:notifications@github.com] Sent: Friday, February 19, 2016 2:23 AM To: ocpnetworking-wip/oom oom@noreply.github.com Subject: [oom] add ethtool support and a collectd plugin (#3)

Hi Don,

Here are some changes to add a ethtool "shim" and a python collectd plugin. It all seems to work. I'll attach screenshot of grafana in action. It's not meant to be pretty, just evidence that it works.

https://cloud.githubusercontent.com/assets/4682074/13172924/89bd7580-d6af-11e5-8578-2b3e1cdff3b3.png

You can view, comment on, or merge this pull request online at:

https://github.com/ocpnetworking-wip/oom/pull/3

Commit Summary

File Changes

Patch Links:

— Reply to this email directly or view it on GitHub https://github.com/ocpnetworking-wip/oom/pull/3 .

donboll commented 8 years ago

Dustin,

I’m working through your changes, so far, I’m loving it. BTW, it passed all my tests immediately, so I’m impressed.

One change you made in oomlib.py, looks like this:

numports = oomsouth.oom_get_portlist(0, 0)

if numports < 0:

    raise RuntimeError("oom_get_portlist error: %d" % numports)

elif numports == 0:

    return list()

Does 0 in this case mean there are zero ports, in which case you just return an empty list? Or does zero in this case mean that the portlist is already uptodate?

I need to know, because I will soon be dealing with 0 vs 1 returned by oom_get_portlist(). I need to know if I’m going to see that with the (0,0) parameters or the (portlist, size) parameters.

The change is good either way, I’ll accept it as is.

Thanks

Don

From: Dustin Byford [mailto:notifications@github.com] Sent: Friday, February 19, 2016 2:23 AM To: ocpnetworking-wip/oom oom@noreply.github.com Subject: [oom] add ethtool support and a collectd plugin (#3)

Hi Don,

Here are some changes to add a ethtool "shim" and a python collectd plugin. It all seems to work. I'll attach screenshot of grafana in action. It's not meant to be pretty, just evidence that it works.

https://cloud.githubusercontent.com/assets/4682074/13172924/89bd7580-d6af-11e5-8578-2b3e1cdff3b3.png

You can view, comment on, or merge this pull request online at:

https://github.com/ocpnetworking-wip/oom/pull/3

Commit Summary

File Changes

Patch Links:

— Reply to this email directly or view it on GitHub https://github.com/ocpnetworking-wip/oom/pull/3 . https://github.com/notifications/beacon/AP1RJ7DuUoeHN_mqKODETlAFgIXmUY8Rks5pluShgaJpZM4Hd3Tb.gif