openconfig / featureprofiles

Feature Profiles are groups of OpenConfig paths and tests which verify their behavior
Apache License 2.0
52 stars 149 forks source link

RT 1.3 route_propagation_test.go #1078

Closed cprabha closed 1 year ago

cprabha commented 1 year ago

Hi,

We are getting below issue while running RT 1.3 route_propagation_test.go. Please could you help to resolve it. ATE rib verification api calls are failing with render issues. Do we need to change anything in rib verification API calls ?

Error:

route_propagation_test.go:417: Await(t) on ate(10.92.196.126) at &{{NetworkInstance_Protocol_Bgp_Rib_AfiSafi_Ipv4Unicast_Neighbor_AdjRibInPre_Route true 0xc0029bfe60 0x5df6480 0x5df6520 0x5df6580 true}}: error receiving gNMI response: failed to render notifications: could not extract set leaves from modified struct: error from ForEachDataField iteration: nil value for key Index
    nil value for key Index
    nil value for key Index
    nil value for key Index
    nil value for key Index
    nil value for key Index
    nil value for key Index
    nil value for key Index

route_propagation_test.go:429: Await(t) on ate(10.92.196.126) at &{{NetworkInstance_Protocol_Bgp_Rib_AfiSafi_Ipv6Unicast_Neighbor_AdjRibInPre_Route true 0xc005809e00 0x5e75fc0 0x5e76060 0x5e760c0 true}}: error receiving gNMI response: failed to render notifications: could not extract set leaves from modified struct: error from ForEachDataField iteration: nil value for key Index nil value for key Index nil value for key Index nil value for key Index nil value for key Index nil value for key Index nil value for key Index

Thanks, Prabha

greg-dennis commented 1 year ago

@wenovus, can you help us understand the error from ygot.Diff here?

wenovus commented 1 year ago

Is it from https://github.com/openconfig/ondatra/blob/main/internal/ixgnmi/ixgnmi.go#L150? If so, it looks like one of the input dev objects has a list element whose key value is missing. So my guess is fetch is creating such a list element somehow. This is invalid since all list elements must have its keys populated.

greg-dennis commented 1 year ago

I found the bug and you can expect a fix merged by end of week.

cprabha commented 1 year ago

Thanks @greg-dennis , @wenovus .

greg-dennis commented 1 year ago

This has been fixed in https://github.com/openconfig/ondatra/releases/tag/v0.1.5

cprabha commented 1 year ago

Thanks Greg.
Is this merged with https://github.com/openconfig/featureprofiles ?

greg-dennis commented 1 year ago

@cprabha The featureprofiles go.mod has not been updated to require that latest version of Ondatra, but you can update it independently for your build. I can separately work on updating the featureprofiles go.mod file to require it.

greg-dennis commented 1 year ago

@cprabha, featureprofiles has now been updated to require that version of Ondatra as well

cprabha commented 1 year ago

Thanks Greg. Test is working fine now.

-Prabha

Juniper Business Use Only From: Greg Dennis @.> Sent: Friday, February 10, 2023 8:29 AM To: openconfig/featureprofiles @.> Cc: Prabha Chethan @.>; Mention @.> Subject: Re: [openconfig/featureprofiles] RT 1.3 route_propagation_test.go (Issue #1078)

[External Email. Be cautious of content]

@cprabhahttps://urldefense.com/v3/__https:/github.com/cprabha__;!!NEt6yMaO-gk!C9I8FKqFLCIRy6OYS9iGXcBfFKaDqxJ759TtrctfH4_lt1x1DSgyWOeaOlhB7J7DUZZIOEUphywBqIFWBt7HKZ5r$, featureprofiles has now been updated to require that version of Ondatra as well

- Reply to this email directly, view it on GitHubhttps://urldefense.com/v3/__https:/github.com/openconfig/featureprofiles/issues/1078*issuecomment-1426050925__;Iw!!NEt6yMaO-gk!C9I8FKqFLCIRy6OYS9iGXcBfFKaDqxJ759TtrctfH4_lt1x1DSgyWOeaOlhB7J7DUZZIOEUphywBqIFWBv3M5rlH$, or unsubscribehttps://urldefense.com/v3/__https:/github.com/notifications/unsubscribe-auth/AHCEB5TADYDBUOGUBP7HNJ3WWZUEDANCNFSM6AAAAAAUUO3IC4__;!!NEt6yMaO-gk!C9I8FKqFLCIRy6OYS9iGXcBfFKaDqxJ759TtrctfH4_lt1x1DSgyWOeaOlhB7J7DUZZIOEUphywBqIFWBjZG62bD$. You are receiving this because you were mentioned.Message ID: @.**@.>>