search

openconfig / featureprofiles

Feature Profiles are groups of OpenConfig paths and tests which verify their behavior
Apache License 2.0
53 stars 150 forks source link

ping_test.go : correction needed in error messages #212

Open yashikakn opened 2 years ago

yashikakn commented 2 years ago

Hi, The error messages in below lines needs correction.

Eg: Error message [here] (https://github.com/openconfig/featureprofiles/blob/main/feature/gnoi/tests/ping_test/ping_test.go#L444-L445) is printed when the value of ping 'Sequence' received is not as expected. But the message states there is error in ping 'Time' which is misleading.

Similar corrections needed in below lines too: (https://github.com/openconfig/featureprofiles/blob/main/feature/gnoi/tests/ping_test/ping_test.go#L456-L457)

(https://github.com/openconfig/featureprofiles/blob/main/feature/gnoi/tests/ping_test/ping_test.go#L459-L460)

(https://github.com/openconfig/featureprofiles/blob/main/feature/gnoi/tests/ping_test/ping_test.go#L468-L469)

Thanks.

sezhang2 commented 2 years ago

Please check if you still see the issue with the latest version: