openconfig / featureprofiles

Feature Profiles are groups of OpenConfig paths and tests which verify their behavior
Apache License 2.0
51 stars 147 forks source link

RT-2.1: Base IS-IS Process and Adjacencies #702

Open trathod1 opened 1 year ago

trathod1 commented 1 year ago

During execution of test feature/experimental/isis/ate_tests/base_adjacencies_test/base_adjacencies_test.go, it configures ISIS using addISISOC call in feature/experimental/isis/ate_tests/internal/session/session.go.

In this function, while configuring ISIS, it does not configure the config.enabled path for ISIS protocol. This is causing ISIS session to remain admin disabled.

In the below code, when prot.Enabled = ygot.Bool(true) is added, the ISIS session comes up fine. It should be added like in line-5 below.

1. // addISISOC configures basic IS-IS on a device.
2. func addISISOC(dev *oc.Root, areaAddress, sysID, ifaceName string) {
3.     inst := dev.GetOrCreateNetworkInstance(*deviations.DefaultNetworkInstance)
4.     prot := inst.GetOrCreateProtocol(PTISIS, ISISName)
5.     prot.Enabled = ygot.Bool(true)
6.     isis := prot.GetOrCreateIsis()

I see in other scripts for configuring static-route it is getting enabled at feature/gribi/ate_tests/ack_in_presence_other_routes/route_ack_test.go -

// configStaticRoute configures a static route.
func configStaticRoute(t *testing.T, dut *ondatra.DUTDevice, prefix string, nexthop string) *telemetry.NetworkInstance_Protocol {
    ni1 := dut.Config().NetworkInstance(*deviations.DefaultNetworkInstance).Get(t)
    static := ni1.GetOrCreateProtocol(telemetry.PolicyTypes_INSTALL_PROTOCOL_TYPE_STATIC, *deviations.StaticProtocolName)
    static.Enabled = ygot.Bool(true)
    static.Identifier = telemetry.PolicyTypes_INSTALL_PROTOCOL_TYPE_STATIC
sonhyoung commented 1 year ago

@xw-g