search

openconfig / gnmi

gRPC Network Management Interface
Apache License 2.0
459 stars 196 forks source link

Fix proto generation script and improper imports. #135

Open asauravpica8 opened 1 year ago

asauravpica8 commented 1 year ago

The complie_protos.sh script seems to be failing right now because of the incorrect import paths in the protoc command. Some imports in the gnmi.proto, target.proto and fake.proto also fail.

There are other instances of these failures being talked about in blogs like these.

google-cla[bot] commented 1 year ago

Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

View this failed invocation of the CLA check for more information.

For the most up to date status, view the checks section at the bottom of the pull request.

asauravpica8 commented 1 year ago

@robshakir PTAL! 🙏

asauravpica8 commented 1 year ago

While we figure out the container-based proto generations as the right architecture going forward, could we accept this PR to fix broken builds in the meantime? @robshakir @n0shut @marcushines Appreciate your time 🙏