search

openconfig / gnmi

gRPC Network Management Interface
Apache License 2.0
459 stars 196 forks source link

Added CommitSetRollbackDuration action for Commit Confirmed extension #164

Closed hellt closed 6 months ago

hellt commented 8 months ago

This is an alternative version to #161. In this version, a specific action is added to denote the Set Rollback Duration for the Commit Confirmed action.

hellt commented 7 months ago

@kidiyoor @dplore Hi gentlemen; I wonder how do we proceed with this one? I am fine with following the @kidiyoor suggestion and moving on with the separate action (which is the case expressed in this PR)

kidiyoor commented 7 months ago

LGTM. Please update https://github.com/openconfig/reference/blob/master/rpc/gnmi/gnmi-commit-confirmed.md as well.

hellt commented 7 months ago

LGTM. Please update https://github.com/openconfig/reference/blob/master/rpc/gnmi/gnmi-commit-confirmed.md as well.

Thanks @kidiyoor , raised https://github.com/openconfig/reference/pull/203 for this

dplore commented 7 months ago

This is a last call for comments. This is planned to merge on Feb 15, 2024.

hellt commented 6 months ago

@dplore @kidiyoor with the recent commit I added generated stubs for Go and Py so that we can add this functionality to openconfig/gnmic client.

hellt commented 6 months ago

Hi @dplore The planned merge date was on Feb 15. Is anything left that is gating this?

dplore commented 6 months ago

Hi @dplore The planned merge date was on Feb 15. Is anything left that is gating this?

Thanks for the ping!

robshakir commented 6 months ago

This should have been merged upstream.