openconfig / gnmi

gRPC Network Management Interface
Apache License 2.0
478 stars 197 forks source link

gNmi Subscribe, gNmi gnxi #47

Closed idefixcert closed 5 years ago

idefixcert commented 5 years ago

Is there a plan to combine gnmi subscribe of this repo and the gnxi implementation.

I you would start to implement an gnmi target, would you start at gnxi or at gnmi subscribe and add the rest?

Is there a way to use the YANG models for validation before they are stored in the cache? Can me someone point to the right direction?

gcsl commented 5 years ago

There currently is no plan to combine the gnmi and gnxi repositories. Although there is an implementation of gnmi subscribe in this repository, it is in the form of an aggregate collector that can subscribe to multiple targets and then service multiple clients on behalf of those targets. This code could also be used as a reference while implementing a target and supporting subscribe but it is not primarily designed to be a target implementation. Feel free to direct questions about implementation here or in the reference repository.

https://github.com/openconfig/reference/tree/master/rpc/gnmi

On Wed, Jan 30, 2019 at 1:03 AM idefixcert notifications@github.com wrote:

Is there a plan to combine gnmi subscribe of this repo and the gnxi implementation.

I you would start to implement an gnmi target, would you start at gnxi or at gnmi subscribe and add the rest?

— You are receiving this because you are subscribed to this thread. Reply to this email directly, view it on GitHub https://github.com/openconfig/gnmi/issues/47, or mute the thread https://github.com/notifications/unsubscribe-auth/ARfILw43N445Z474QSYFO8X9jCWrlnALks5vIV_ngaJpZM4aZvqn .

idefixcert commented 5 years ago

Thanx for the reply. I did a code dive in the gnmi subscribe repository today, that looks promising. Am I right the match does not allow to use filters other than glob?

gcsl commented 5 years ago

That is correct.

On Thu, Jan 31, 2019 at 12:30 PM idefixcert notifications@github.com wrote:

Thanx for the reply. I did a code dive in the gnmi subscribe repository today, that looks promising. Am I right the match does not allow to use filters other than glob?

— You are receiving this because you commented. Reply to this email directly, view it on GitHub https://github.com/openconfig/gnmi/issues/47#issuecomment-459494223, or mute the thread https://github.com/notifications/unsubscribe-auth/ARfIL9DjieotsLpf1o1GdRhOLsn3SJQJks5vI1JOgaJpZM4aZvqn .

idefixcert commented 5 years ago

Ok one more: the ctree allows to store data in the tree. If I consider to store interfaces in the tree how would that work? How to model the path? /interfaces/interface[name=a]/config/AdminStatus/up /interfaces/interface[name=b]/config/AdminStatus/up would that be the idea?