search

openconfig / gnmic

gNMIc is a gNMI CLI client and collector
https://gnmic.openconfig.net
Apache License 2.0
166 stars 52 forks source link

api support to update target subscriptions directly #461

Closed jarrodb closed 3 weeks ago

jarrodb commented 1 month ago

This PR introduces a new API endpoint /config/targets/:id/subscriptions designed to allow users to directly update the subscription list for a specific target without the need to delete and re-add the target.

The use case for this endpoint allows us to build an initial target list with a single subscription for system information (i.e. eos_native:/Eos/image for EOS or /system/information/version for SRL) that we can update with subscriptions for specific paths that vary across vendor versions to accommodate breaking changes in models.

google-cla[bot] commented 1 month ago

Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

View this failed invocation of the CLA check for more information.

For the most up to date status, view the checks section at the bottom of the pull request.

karimra commented 3 weeks ago

Thanks for contribution!

jarrodb commented 3 weeks ago

Oh I was going to get a test pushed first (I'll still do that)

karimra commented 3 weeks ago

Sorry, I understood you will do it in a separate PR