openconfig / gnoi

gRPC Network Operations Interface (gNOI) defines a set of gRPC-based microservices for executing operational commands on network devices.
Apache License 2.0
160 stars 67 forks source link

fix copy in regenerate-files script #194

Closed brianneville closed 5 months ago

brianneville commented 5 months ago

As in the original regenerate-files script from https://github.com/openconfig/gnsi/pull/37/files#diff-fc93ffaaee0a108cd0141877980a22c2c5f782b529e4561cd11243753b91eed8 the copy should be from "${BASE}"/"${pkg}"/"${proto}"_go_proto_/"${GNOI_NS}"/"${pkg}"/*.pb.go to the target package rather than the "${BASE}"/"${pkg}"/"${proto}"_go_proto_/"${GNOI_NS}"/"${proto}"/*.pb.go which was in the base patch e.g. the files for packet link qualification will be under linkqual_go_proto_/github.com/openconfig/gnoi/packet_link_qualification/packet_link_qualification.pb.go

brianneville commented 5 months ago

related issue thread: https://github.com/openconfig/gnoi/issues/173#issuecomment-2098982800

coveralls commented 5 months ago

Pull Request Test Coverage Report for Build 8990651044

Details


Changes Missing Coverage Covered Lines Changed/Added Lines %
packet_capture/packet_capture_grpc.pb.go 0 38 0.0%
packet_link_qualification/packet_link_qualification_grpc.pb.go 0 137 0.0%
<!-- Total: 0 175 0.0% -->
Totals Coverage Status
Change from base Build 8911885186: -0.001%
Covered Lines: 166
Relevant Lines: 13817

💛 - Coveralls