search

openconfig / gnoigo

Go library implementing a gNOI client
Apache License 2.0
4 stars 5 forks source link

Add OS Activate and OS Verify Operations #24

Closed asafsonnv closed 8 months ago

google-cla[bot] commented 9 months ago

Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

View this failed invocation of the CLA check for more information.

For the most up to date status, view the checks section at the bottom of the pull request.

asafsonnv commented 9 months ago

Can we merge it?

greg-dennis commented 9 months ago

Sorry for the delay. I was away on vacation last week. Can you just add a few single unit tests to os_test.go? These are simple, unary operations, so they would look like TestTime: https://github.com/openconfig/gnoigo/blob/main/system/system_test.go#L312

asafsonnv commented 8 months ago

Hi sorry I accidentally did force push. can we revert it? or should I create a new MR with all the changes?