dplore
commented
2 days ago Hi Rohit, Feel free to create a PR to add the additional keys. We can review and approve
On Thu, Sep 19, 2024 at 3:57 AM Rohit @.***> wrote:
Hi I see that in gnsi/credentialz/credentialz.proto https://github.com/openconfig/gnsi/blob/main/credentialz/credentialz.proto the keyType supported are KEY_TYPE_ECDSA_P_256, KEY_TYPE_ECDSA_P_521, KEY_TYPE_ED25519,KEY_TYPE_RSA_2048, KEY_TYPE_RSA_4096.
Earlier there was no differentiation on the basis of bit size. This was brought in by @nmahabaleshwar https://github.com/nmahabaleshwar commit https://github.com/openconfig/gnsi/commit/eb38162f1f5e5b36159a4f8810d98032f864fad8. And then another commit by @marcushines https://github.com/marcushines commit https://github.com/openconfig/gnsi/pull/80/commits that was for rsa key type for 4096 and 2048.
Can you guys help me know why RSA 3072 and ECDSA_P_384 were not included in the proto
— Reply to this email directly, view it on GitHub https://github.com/openconfig/gnsi/issues/205, or unsubscribe https://github.com/notifications/unsubscribe-auth/ABMCGM7JIXTCNNLUOZGYLE3ZXKU2DAVCNFSM6AAAAABOPUU4TGVHI2DSMVQWIX3LMV43ASLTON2WKOZSGUZTKOJZHE2DMNY . You are receiving this because you are subscribed to this thread.Message ID: @.***>
rohit21187
Hi I see that in gnsi/credentialz/credentialz.proto the keyType supported are KEY_TYPE_ECDSA_P_256, KEY_TYPE_ECDSA_P_521, KEY_TYPE_ED25519,KEY_TYPE_RSA_2048, KEY_TYPE_RSA_4096.
Earlier there was no differentiation on the basis of bit size. This was brought in by @nmahabaleshwar commit for ecdsa. And then another commit by @marcushines commit that was for rsa key type for 4096 and 2048.
I believe we are still missing support for RSA 3072 and ECDSA_P_384.