search

openconfig / goyang

YANG parser and compiler to produce Go language objects
Apache License 2.0
221 stars 86 forks source link

Fix an age-old bug with `FromFloat` handling of negatives. #268

Closed robshakir closed 4 months ago

robshakir commented 4 months ago 
 * (M) pkg/yang/types_builtin(_test)?.go
    - This change squashes a bug that has existed for a long time
      in `FromFloat`, but only shows up on arm64. I finally have an
      arm64 machine and so found the issue. It was originally reported
      in https://github.com/openconfig/ygot/issues/766. The issue is
      that uint64 of a negative float64 is undefined  -- and on arm64
      on darwin returns 0, which made some test cases fail only on this
      architecture.
coveralls commented 4 months ago

Coverage Status

coverage: 77.848% (+0.005%) from 77.843% when pulling 69235d4e0d6406e6950a9448191fdefea66e4dd8 on fix-negatives into dfbf7ba9ba8401846d2a2f0ee284c5d6181fd9a0 on master.