search

openconfig / grpctunnel

A TCP-over-gRPC Tunnel
Apache License 2.0
81 stars 24 forks source link

missing Capabilities message in tunnel.proto #12

Closed dliu2223 closed 3 years ago

dliu2223 commented 3 years ago

The Capabilities message was defined in previous version as message Capabilities { bool handler = 1; // Whether a handler is installed on the endpoint. } Should the Capabilities defined in gNMI be used in this proposal

Thanks

David

gcsl commented 3 years ago

Capabilities message in gRPC tunnel had no correlation with the Capabilities RPC in gNMI and the name conflict was coincidental. The original intent of Capabilities message in this prototype tunnel library was to allow for a single target to enumerate multiple protocols (e.g. gNMI/gNOI and ssh). But that was subsumed in the update where the tunnel target can enumerate a type specifically and register itself multiple times for each protocol. Thus Capabilities message was removed.

On Fri, Feb 5, 2021 at 4:18 PM dliu2223 notifications@github.com wrote:

The Capabilities message was defined in previous version as message Capabilities { bool handler = 1; // Whether a handler is installed on the endpoint. } Should the Capabilities defined in gNMI be used in this proposal

Thanks

David

— You are receiving this because you are subscribed to this thread. Reply to this email directly, view it on GitHub https://github.com/openconfig/grpctunnel/issues/12, or unsubscribe https://github.com/notifications/unsubscribe-auth/AEL4QLYUSDB4VKXJZ2APLOLS5ROBBANCNFSM4XFOJHZA .

dliu2223 commented 3 years ago

Thanks

David