openconfig / kne

Apache License 2.0
215 stars 65 forks source link

Not allowed to deploy cluster without controller #353

Closed hmntsharma closed 1 year ago

hmntsharma commented 1 year ago

Hi All,

Is there any way to deploy the cluster without any controllers? Please. There is no need for it with Cisco XRd images.

$ cat kind-bridge.yaml
# kind-bridge.yaml cluster config file sets up a kind cluster where default PTP CNI plugin
# is swapped with the Bridge CNI plugin.
# Bridge CNI plugin is required by some Network OSes to operate.
cluster:
  kind: Kind
  spec:
    name: kne
    recycle: True
    version: v0.17.0
    image: kindest/node:v1.26.0
    config: ../../kind/kind-no-cni.yaml
    additionalManifests:
      - ../../manifests/kind/kind-bridge.yaml
ingress:
  kind: MetalLB
  spec:
    manifest: ../../manifests/metallb/manifest.yaml
    ip_count: 100
cni:
  kind: Meshnet
  spec:
    manifest: ../../manifests/meshnet/grpc/manifest.yaml
$ kne deploy kind-bridge.yaml
Error: no controllers specified

Thanks!

alexmasi commented 1 year ago

Which commit is your kne cli built from?

This was recently fixed to only log and not error out: https://github.com/openconfig/kne/blob/beb4d415438c950c8fc9efc5dcf35a3d12cf99e4/cmd/deploy/deploy.go#L86

hmntsharma commented 1 year ago

My installation was 2 week old. So I built it again with the latest source and it works without the cluster now!

Thanks!

Deployment Logs now:

I0411 02:10:19.893399    4428 deploy.go:86] no controllers specified
I0411 02:10:19.894028    4428 deploy.go:141] Deploying cluster...