openconfig / kne

Apache License 2.0
216 stars 65 forks source link

Add credential refresh for GAR registries in kind #479

Closed alexmasi closed 9 months ago

alexmasi commented 9 months ago

Previously if GAR access was configured for kind clusters using kne deploy, the credential would expire after 1hr. This PR adds refresh before a new topology creation if extra GAR docker creds are found in the kind cluster.

github-actions[bot] commented 9 months ago

Pull Request Test Coverage Report for Build 7662585842


Changes Missing Coverage Covered Lines Changed/Added Lines %
topo/topo.go 1 4 25.0%
deploy/deploy.go 18 23 78.26%
cluster/kind/kind.go 117 131 89.31%
exec/run/run.go 23 37 62.16%
<!-- Total: 159 195 81.54% -->
Totals Coverage Status
Change from base Build 7661883450: 0.07%
Covered Lines: 4328
Relevant Lines: 6506

💛 - Coveralls
alexmasi commented 9 months ago

Still need to add the test cases for cluster/kind/kind_test.go

Other than that it should be ready for initial review