Add the ability to provide pre-generated certs

openconfig / kne

Apache License 2.0

214 stars 64 forks source link

Add the ability to provide pre-generated certs #545

Open alexmasi opened 2 months ago

alexmasi commented 2 months ago

Currently self-signed is the only cert type provided, this PR adds another option to the topo proto but does not yet add support to node impls to use the new field.

A follow up PR will use the field.

coveralls commented 2 months ago

Pull Request Test Coverage Report for Build 9768506569

Details

0 of 0 changed or added relevant lines in 0 files are covered.
1 unchanged line in 1 file lost coverage.
Overall coverage decreased (-0.01%) to 65.198%

Files with Coverage Reduction	New Missed Lines	%
topo/node/arista/arista.go	1	71.34%
<!--	Total:	1		-->

Totals
Change from base Build 9765987846:	-0.01%
Covered Lines:	4646
Relevant Lines:	7126

💛 - Coveralls

chrisy commented 2 months ago

This has been top of mind for me, so thanks for tackling it. Generating certs is the slowest part of topology creation in many cases!