search

openconfig / kne

Apache License 2.0
214 stars 64 forks source link

Node Selector Feature #549

Open imanless opened 1 month ago

imanless commented 1 month ago

Is it possible to define a certain worker node for each lab node in the topology file, meaning one can choose which worker node should the lab node be deployed on, instead of relying on the kubernetes default scheduler?

alexmasi commented 1 month ago

This is not something we have explored. Although I could see that being very useful for cases when you have a topo with some nodes requiring nested virt support and only some worker nodes that supported nested virt for example.

This may not be too difficult to add using the existing labels field: https://github.com/openconfig/kne/blob/b5d78250ff387e7d472a830b0818272d5e338b96/proto/topo.proto#L70 which get applied to the pod: https://github.com/openconfig/kne/blob/b5d78250ff387e7d472a830b0818272d5e338b96/topo/node/node.go#L453

Contributions are welcome.