Set a maximum amount of time to wait for an image to be pulled

bormanp commented 1 month ago

after seeing ErrImagePull.

bormanp commented 1 month ago

/gcbrun

github-actions[bot] commented 1 month ago

Pull Request Test Coverage Report for Build 9993408083

Details

12 of 12 (100.0%) changed or added relevant lines in 1 file are covered.
No unchanged relevant lines lost coverage.
Overall coverage increased (+0.06%) to 65.3%

Totals
Change from base Build 9864302534:	0.06%
Covered Lines:	4665
Relevant Lines:	7144

💛 - Coveralls

bormanp commented 1 month ago

UPDATE 2: I had opened the "Details" link along side the check. It was of very little help. Looking at the diffs I see where the blank like was (not at the end of a file). Pushed the commit to remove that one newline.

UPDATE: It appears lint decided to start passing.

I am not sure why lint is complaining about an empty line. The only files whose last line is empty or consists solely of whitespace are:

./topo/node/cisco/testdata/push_config_success
./cloudbuild/vendors/topology.textproto
./cloudbuild/vendors/testbed.textproto
./cloudbuild/vendors/juniper.cfg
./examples/arista/ceos-150/arista.cfg
./examples/cisco/xrd/r2.config
./examples/cisco/xrd/r1.config
./examples/cisco/8000e/8000e.pb.txt
./examples/cisco/xrd-traffic/r2.config
./examples/cisco/xrd-traffic/r1.config
./examples/nokia/srlinux-services/2node-srl-ixr6-with-oc-services.pbtxt
./examples/nokia/srlinux-cert/2node-srl-with-cert.pbtxt
./examples/juniper/cptx-ixia/cptx-ixia.pb.txt
./manifests/base/kustomization.yaml
./.mk/kind.mk

None of those are Go files.

bormanp commented 1 month ago

The presubmit seems to be failing in TestMetalLBSpec which is unrelated to this change.

openconfig / kne