openconfig / kne

Apache License 2.0
214 stars 64 forks source link

Wait for manifest-issued deployments to complete before proceeding with Topology generation #556

Closed LarsxGitHub closed 1 month ago

LarsxGitHub commented 1 month ago

This is needed to ensure that any deployments that are started by the additional manifests (e.g., a mutating webhook) are completed before proceeding with later stages such as topology creation.

Not waiting for the deployment to finish before starting to create the topology results in potential race conditions in which a webhook isn't listening yet but is already requested to address admission requests, leading to "connection refused" error messages.

alexmasi commented 1 month ago

/gcbrun