Closed bortok closed 2 years ago
Tested with #83, looks good using both types of syntax:
host1
syntax now produces
Command:
/start.sh
Args:
-s
host2
syntax now produces
Command:
/start.sh
-s
Both work as expected.
There is a default value for
command
parameter for HOST nodes:/bin/sh -c sleep 2000000000000
. This value should be replaced if acommand
is present in a topology definition, but instead, both are being merged. For example:results in the following POD spec
Alternatively, if a
command
is defined via an array like this:we get
The issue seems to be originating at https://github.com/google/kne/blob/main/topo/node/host/host.go#L26. From Merge func documentation the expected behavior matches what is observed: