github-actions[bot]
commented
7 months ago Pull Request Test Coverage Report for Build 8346921455
Details
- 14 of 65 (21.54%) changed or added relevant lines in 2 files are covered.
- No unchanged relevant lines lost coverage.
- Overall coverage increased (+0.001%) to 2.673%
| Changes Missing Coverage | Covered Lines | Changed/Added Lines | % | ||
|---|---|---|---|---|---|
| bgp/gobgp.go | 11 | 62 | 17.74% | ||
| <!-- | Total: | 14 | 65 | 21.54% | --> |
| Totals | |
|---|---|
| Change from base Build 8334633740: | 0.001% |
| Covered Lines: | 17397 |
| Relevant Lines: | 650868 |
Sync fix from upstream GoBGP and add missing unit tests.
Also added sanity community set checks into integration_test/prefix_test to avoid creating another integration test that tests the same logic. Added TODO for race conditions discovered that are triggered by subtests when BGP policy and routes are cleared and re-created. This will block policy logic tests that involve re-advertising the same route under different policies, but will work for tests that are checking a static set of policies, which is the current set of tests I'm looking at to support.