github-actions[bot]
commented
6 months ago Pull Request Test Coverage Report for Build 8714813393
Details
- 68 of 90 (75.56%) changed or added relevant lines in 3 files are covered.
- No unchanged relevant lines lost coverage.
- Overall coverage increased (+0.02%) to 2.765%
| Changes Missing Coverage | Covered Lines | Changed/Added Lines | % | ||
|---|---|---|---|---|---|
| lemming.go | 4 | 6 | 66.67% | ||
| gnmi/fakedevice/fakedevice.go | 13 | 17 | 76.47% | ||
| gnoi/gnoi.go | 51 | 67 | 76.12% | ||
| <!-- | Total: | 68 | 90 | 75.56% | --> |
| Totals | |
|---|---|
| Change from base Build 8709035692: | 0.02% |
| Covered Lines: | 18012 |
| Relevant Lines: | 651511 |
gNOI-3.1: Complete Chassis Rebootpass.The Reboot/CancelReboot behaviour is taken from the comments in https://github.com/openconfig/gnoi/blob/main/system/system.proto. The implementation uses non-straightforward concurrency for cleaning-up concurrency signals, but I didn't see another way to do this for now since the spawned goroutine has a limited lifetime.