openconfig / lemming

An OpenConfig reference device implementation
Apache License 2.0
31 stars 9 forks source link

Add support for plumbing gRIBI server options through lemming. #451

Closed robshakir closed 4 months ago

robshakir commented 4 months ago
 * (M) lemming.go
 * (M) gribi/gribi.go
  - for some behaviours, there is a need to change the underlying RIB functionality
    in the gRIBI server as a lemming is created. this change plumbs some options
    through to allow lemmings to be created using this method.
DanG100 commented 4 months ago

Run make buildfile to update all the build files. probably need to include repositories.bzl as well

github-actions[bot] commented 4 months ago

Pull Request Test Coverage Report for Build 9963087255

Details


Changes Missing Coverage Covered Lines Changed/Added Lines %
lemming.go 1 5 20.0%
<!-- Total: 6 10 60.0% -->
Files with Coverage Reduction New Missed Lines %
dataplane/standalone/pkthandler/pktiohandler/pktiohandler.go 8 46.37%
<!-- Total: 8 -->
Totals Coverage Status
Change from base Build 9915464407: 0.0%
Covered Lines: 18580
Relevant Lines: 658352

💛 - Coveralls
robshakir commented 4 months ago

@DanG100 It looks like this "build and test" workflow is flaky. It passes locally w/KNE and periodically passes here. I don't think this is based on my change. Can you PTAL?

DanG100 commented 4 months ago

@DanG100 It looks like this "build and test" workflow is flaky. It passes locally w/KNE and periodically passes here. I don't think this is based on my change. Can you PTAL?

yeah, known issue on github runner, haven't had a chance to debug more

robshakir commented 4 months ago

@DanG100 It looks like this "build and test" workflow is flaky. It passes locally w/KNE and periodically passes here. I don't think this is based on my change. Can you PTAL?

yeah, known issue on github runner, haven't had a chance to debug more

No problem, just wanted to validate -- backlog deflaking sgtm.