Implement L2MC via ACL redirect. - Githubissues

openconfig / lemming

An OpenConfig reference device implementation

Apache License 2.0

31 stars 9 forks source link

Implement L2MC via ACL redirect. #454

Closed guoshiuan closed 3 months ago

github-actions[bot] commented 4 months ago

Pull Request Test Coverage Report for Build 10013079730

Details

137 of 163 (84.05%) changed or added relevant lines in 5 files are covered.
2 unchanged lines in 1 file lost coverage.
Overall coverage increased (+0.02%) to 2.851%

Changes Missing Coverage	Covered Lines	Changed/Added Lines	%
dataplane/saiserver/switch.go	18	20	90.0%
dataplane/forwarding/protocol/metadata/metadata.go	1	6	16.67%
dataplane/saiserver/acl.go	1	10	10.0%
dataplane/saiserver/l2.go	116	126	92.06%
<!--	Total:	137	163	84.05%	-->

Files with Coverage Reduction	New Missed Lines	%
bgp/gobgp.go	2	41.87%
<!--	Total:	2		-->

Totals
Change from base Build 9998422867:	0.02%
Covered Lines:	18777
Relevant Lines:	658562

💛 - Coveralls

DanG100 commented 3 months ago

can add UT for this?

guoshiuan commented 3 months ago

can add UT for this?

Done