openconfig / public

Repository for publishing OpenConfig models, documentation, and other material for the community.
Apache License 2.0
899 stars 656 forks source link

Enabling Segment Routing (SR) for OSPFv2 #1055

Open jardel-lucca-venko opened 8 months ago

jardel-lucca-venko commented 8 months ago

Hi,

We can enable SR for IS-IS with:

.../network-instance/protocols/protocol/isis/global/segment-routing/config/enabled

This segment-routing container is defined in openconfig-segment-routing.yang ("oc-sr") sr-igp-top grouping.

It was added in commit 55573d7 (openconfig-isis.yang):

   grouping isis-global-base {
     description
       "This grouping describes ISIS Global router.";

     ...
+
+    uses oc-sr:sr-igp-top;
   }

However, it would be useful to have this for OSPFv2 as well.

I believe we could similarly include sr-igp-top in .../protocol/ospfv2/global container (openconfig-ospfv2-global.yang):

   grouping ospfv2-global-structural {
     description
       "Top level structural grouping for OSPFv2 global parameters";

     container global {
       description
         "Configuration and operational state parameters for settings
         that are global to the OSPFv2 instance";

       ...
+
+      uses oc-sr:sr-igp-top;
     }     
   }

Would such inclusion be acceptable?

Thanks. Jardel Lucca

github-actions[bot] commented 2 months ago

This issue is stale because it has been open 180 days with no activity. If you wish to keep this issue active, please remove the stale label or add a comment, otherwise will be closed in 14 days.

dplore commented 2 months ago

Hi @jardel-lucca-venko, if you intend to use ospf with segment routing and are willing to create a PR with the yang model, find the implementation references confirming the support and a good reviewer with some OSPF/SR experience we would welcome the contribution!

I am not familiar with OSPF support for SR to know if your proposal is valid, but from a distance it sounds like a good approach. If you can provide sufficiently detailed implementation references/documentation I think you could demonstrate in a PR that what's being added is in fact supported by at least 2 implementations. Then the review has a good chance of going smoothly.