openconfig / public

Repository for publishing OpenConfig models, documentation, and other material for the community.
Apache License 2.0
894 stars 652 forks source link

incorrect paths in "when" statements in openconfig-if-aggregate.yang and openconfig-if-ethernet.yang #181

Closed maikesiwei closed 2 months ago

maikesiwei commented 6 years ago

https://github.com/openconfig/public/blob/b37dcd73cb09b4ce0dfa9efe81cf8f8176809b0a/release/models/interfaces/openconfig-if-aggregate.yang#L195

when "oc-if:state/oc-if:type = 'ift:ieee8023adLag' or " + "oc-if:state/oc-if:type = 'oc-ift:IF_AGGREGATE'"

should be

when "oc-if:config/oc-if:type = 'ift:ieee8023adLag' or " + "oc-if:config/oc-if:type = 'oc-ift:IF_AGGREGATE'"

https://github.com/openconfig/public/blob/b37dcd73cb09b4ce0dfa9efe81cf8f8176809b0a/release/models/interfaces/openconfig-if-ethernet.yang#L417

when "oc-if:state/oc-if:type = 'ift:ethernetCsmacd'"

should be

when "oc-if:config/oc-if:type = 'ift:ethernetCsmacd'"

oc-if:state/oc-if:type is not a config node, when compile and load these yang files in nso, it will log error like this:

20-Sep-2018::20:46:07.850 NKG1000135247 ncs[7539]: - The dependency node '/ncs:devices/device/config/oc-if:interfaces/interface/state/type' for node '/ncs:devices/device/config/oc-if:interfaces/interface/oc-lag:aggregation' in module 'tailf-ncs' does not exist 20-Sep-2018::20:46:07.850 NKG1000135247 ncs[7539]: - The dependency node '/ncs:devices/device/config/oc-if:interfaces/interface/state/type' for node '/ncs:devices/device/config/oc-if:interfaces/interface/oc-eth:ethernet' in module 'tailf-ncs' does not exist
github-actions[bot] commented 4 months ago

This issue is stale because it has been open 180 days with no activity. If you wish to keep this issue active, please remove the stale label or add a comment, otherwise will be closed in 14 days.