search

openconfig / public

Repository for publishing OpenConfig models, documentation, and other material for the community.
Apache License 2.0
877 stars 642 forks source link

Sflow model doesnt support same collector IP/port across network-instances #440

Open venkatmahalingam opened 3 years ago

venkatmahalingam commented 3 years ago

Hello @aashaikh

In the below sflow YANG model, collector list doesn't have 'network-instance' as the key, and hence same collector IP & port cant be configured across network-instances, is it possible to add network-instance also as key for collector list with major version change?

https://github.com/openconfig/public/blob/master/release/models/sampling/openconfig-sampling-sflow.yang#L142

robshakir commented 2 years ago

Thanks for this report - we'd be happy to review a PR for this change. There should be no need to have a major version change if the leaves are added in a way that does not change the interpretation of the existing leaves.

venkatmahalingam commented 2 years ago

Thanks for this report - we'd be happy to review a PR for this change. There should be no need to have a major version change if the leaves are added in a way that does not change the interpretation of the existing leaves.

Sure, will create a PR for review, thanks!

github-actions[bot] commented 1 month ago

This issue is stale because it has been open 180 days with no activity. If you wish to keep this issue active, please remove the stale label or add a comment, otherwise will be closed in 14 days.