openconfig / public

Repository for publishing OpenConfig models, documentation, and other material for the community.
Apache License 2.0
879 stars 643 forks source link

'date-code' description from openconfig-platform-transceiver.yang needs to be corrected #476

Closed kannanljuniper closed 1 week ago

kannanljuniper commented 2 years ago

The leaf 'date-code' description from openconfig-platform-transceiver.yang mentioned as "Representation of the transceiver date code, typically stored as YYMMDD" which is misleading as the date format of the current description is not complaint with the type oc-yang:date-and-time format YYYY-MM-DDTHH:MM:SSZ+-hh:mm described in RFC3339 as per openconfig-yang-types.yang OC model. Please review and update with correct description for the leaf 'date-code' from openconfig-platform-transceiver.yang model.

https://github.com/openconfig/public/blob/master/release/models/platform/openconfig-platform-transceiver.yang

leaf date-code {
  type oc-yang:date-and-time;
  description
    "Representation of the transceiver date code, typically
    stored as YYMMDD.  The time portion of the value is
    undefined and not intended to be read.";
}

https://github.com/openconfig/public/blob/master/release/models/types/openconfig-yang-types.yang

typedef date-and-time { type string { pattern '[0-9]{4}-(0[1-9]|1[0-2])-(0[1-9]|[1-2][0-9]|3[0-1])T' + '([0-1][0-9]|2[0-3]):[0-5][0-9]:([0-5][0-9]|60)' + '(.[0-9]+)?(Z|(+-:[0-5][0-9]))'; oc-ext:posix-pattern '^[0-9]{4}-(0[1-9]|1[0-2])-(0[1-9]|[1-2][0-9]|3[0-1])T' + '([0-1][0-9]|2[0-3]):[0-5][0-9]:([0-5][0-9]|60)' + '(.[0-9]+)?(Z|(+-:[0-5][0-9]))$'; } description "A date and time, expressed in the format described in RFC3339. That is to say: YYYY-MM-DDTHH:MM:SSZ+-hh:mm

github-actions[bot] commented 2 months ago

This issue is stale because it has been open 180 days with no activity. If you wish to keep this issue active, please remove the stale label or add a comment, otherwise will be closed in 14 days.