search

openconfig / public

Repository for publishing OpenConfig models, documentation, and other material for the community.
Apache License 2.0
877 stars 642 forks source link

Regarding openconfig-sampling.html : source-address leaf #497

Open RajoJohn opened 2 years ago

RajoJohn commented 2 years ago

Hi OC team, I have a query on openconfig-sampling.html : source-address leaf:

sampling / sflow/ config /source-address

I think this leaf should ideally be under

sampling / sflow/ collectors / collector / config /

I see two reasons for this:

  1. The source address is a collector related information .
  2. Inside the collector config, we allow network instance (aka VRF information). So different collectors may belong to different VRFs, so the source address should be an address belonging to that network instance. ie different collectors may need different source addresses. The global source-address could be used as a default source-address. Also I had seen a query to include VRF as a key to collector. Is the new model with that change published ?

Thanks.

github-actions[bot] commented 1 month ago

This issue is stale because it has been open 180 days with no activity. If you wish to keep this issue active, please remove the stale label or add a comment, otherwise will be closed in 14 days.