search

openconfig / public

Repository for publishing OpenConfig models, documentation, and other material for the community.
Apache License 2.0
888 stars 643 forks source link

Update oc-macsec model to use oc-keychain model #606

Closed m26singhvi closed 1 month ago

m26singhvi commented 2 years ago

Currently, openconfig macsec model - public/release/models/macsec/openconfig-macsec.yang has a keychain container for configuring keys.

Recently, a keychain model was published here - https://github.com/openconfig/public/blob/master/release/models/keychain/openconfig-keychain.yang

which allows configuration of keys as well - most of it is pretty similar to what is present in Macsec model already.

It will be good if the macsec model can remove out the key-chain container and refer to the key-chain model defined globally.

dplore commented 2 years ago

Thanks for the comment! To help speed this along, I encourage you to submit a pull request to make the changes you would like to see. Thank you!

m26singhvi commented 2 years ago

Thanks for taking a look at this. I will soon submit a pull request for this.

github-actions[bot] commented 3 months ago

This issue is stale because it has been open 180 days with no activity. If you wish to keep this issue active, please remove the stale label or add a comment, otherwise will be closed in 14 days.