openconfig / public

Repository for publishing OpenConfig models, documentation, and other material for the community.
Apache License 2.0
894 stars 652 forks source link

statistics in SR TE Policies: does it make sense to have in & out packets #638

Closed oscargdd closed 2 months ago

oscargdd commented 2 years ago

In SR-TE policies the following counters are defined

/network-instances/network-instance/segment-routing/te-policies/te-policy/state/counters/in-labeled-octets /network-instances/network-instance/segment-routing/te-policies/te-policy/state/counters/in-labeled-pkts /network-instances/network-instance/segment-routing/te-policies/te-policy/state/counters/in-octets /network-instances/network-instance/segment-routing/te-policies/te-policy/state/counters/in-pkts /network-instances/network-instance/segment-routing/te-policies/te-policy/state/counters/out-labeled-octets /network-instances/network-instance/segment-routing/te-policies/te-policy/state/counters/out-labeled-pkts /network-instances/network-instance/segment-routing/te-policies/te-policy/state/counters/out-octets /network-instances/network-instance/segment-routing/te-policies/te-policy/state/counters/out-pkts

However, does it make sense to have both in & out statistics? The routers count the packets that match the policy, but not in or out.

vcheny commented 2 years ago

pkts/octets can be different when they are counted on ingress or egress directions. e.g. in-octets doesn't include the segments pushed to the packets while out-octets should. The delta between in-pkts and out-pkts would help in case devices discard some packets subjected to SRTE policies.

github-actions[bot] commented 4 months ago

This issue is stale because it has been open 180 days with no activity. If you wish to keep this issue active, please remove the stale label or add a comment, otherwise will be closed in 14 days.