search

openconfig / public

Repository for publishing OpenConfig models, documentation, and other material for the community.
Apache License 2.0
895 stars 655 forks source link

Aggregate-sid-counters should be keyed by sid instead of mpls-label #728

Closed shraddha-hegde closed 3 months ago

shraddha-hegde commented 2 years ago

/network-instances/network-instance/mpls/signaling-protocol/segment-routing/aggregate-sid-counters/aggregate-sid-counter/state/out-pkts

aggregate-sid-counters use mpls-label as key. In segment routing the SID is constant (not changing) from one node to another. mpls label is derived based on SRGB start and the SID. Segment routing architecture allows the nodes to have different SRGB. The mpls label would change based on neighbor's SRGB. This is problematic for the out-pkts counters because mpls label can be different across the two neighbors.

Model should be updated to use SID as the key for aggregate-sid-counters

earies commented 2 years ago

cc: @dplore @robshakir

Notable deviations for this today

https://github.com/aristanetworks/yang/blob/master/EOS-4.29.0F/release/openconfig/models/mpls/arista-mpls-deviations.yang https://github.com/YangModels/yang/blob/main/vendor/cisco/xr/771/cisco-xr-openconfig-network-instance-deviations.yang

dplore commented 2 years ago

Thanks for reporting the issue. @rgwilton, @rolandphung, @hobbydos for comment

github-actions[bot] commented 5 months ago

This issue is stale because it has been open 180 days with no activity. If you wish to keep this issue active, please remove the stale label or add a comment, otherwise will be closed in 14 days.