search

openconfig / public

Repository for publishing OpenConfig models, documentation, and other material for the community.
Apache License 2.0
878 stars 643 forks source link

In openconfig-keychain model, can key collection be directly inside keychain instead of another indirection via keys container ? #787

Closed m26singhvi closed 5 days ago

m26singhvi commented 1 year ago

In openconfig-keychain model, currently, we have the following hierarchy : 

grouping keychain-key-base {
    description
      "This grouping defines keychain parameters";

  container keys {
    description
    "list of keys to be stored";
      list key {
        key "key-id";
        description
          "List of configured keys for the keychain.";

        leaf key-id {
          type leafref {
            path "../config/key-id";
          }
          description
            "Reference to key id.";
        }
....
....
....

Actual Path being : 

/keychains/keychain[name=*]/keys/key[key-id=*]/key-id
/keychains/keychain[name=*]/keys/key[key-id=*]/receive-lifetime/config/end-time 
/keychains/keychain[name=*]/keys/key[key-id=*]/receive-lifetime/config/start-time
/keychains/keychain[name=*]/keys/key[key-id=*]/send-lifetime/config/end-time
/keychains/keychain[name=*]/keys/key[key-id=*]/send-lifetime/config/start-time
....

In the above paths, why is there keys container at all ? Can keys collection be directly inside the keychain path ?

The paths will become like : 

/keychains/keychain[name=*]/key[key-id=*]/key-id
/keychains/keychain[name=*]/key[key-id=*]/receive-lifetime/config/end-time 
/keychains/keychain[name=*]/key[key-id=*]/receive-lifetime/config/start-time
/keychains/keychain[name=*]/key[key-id=*]/send-lifetime/config/end-time
/keychains/keychain[name=*]/key[key-id=*]/send-lifetime/config/start-time
....

Can this be done or is there a limitation a grouping can't be inside another grouping directly ?

github-actions[bot] commented 2 months ago

This issue is stale because it has been open 180 days with no activity. If you wish to keep this issue active, please remove the stale label or add a comment, otherwise will be closed in 14 days.