search

openconfig / public

Repository for publishing OpenConfig models, documentation, and other material for the community.
Apache License 2.0
899 stars 656 forks source link

Need Info on csnp-enable-on-p2p-links knob - Disable option #890

Open sms-juniper opened 1 year ago

sms-juniper commented 1 year ago

Hi , in ISIS yang version - reference "1.1.0" ,revision "2022-09-20" a new knob was introduced. (https://github.com/openconfig/public/pull/712)

/network-instances/network-instance/protocols/protocol/isis/global/config/csnp-enable-on-p2p-links description: When set to true, ISIS will always enable CSNP on P2P Links. nodetype: leaf (rw) type: boolean default: true

Our views are - Since CSNP is harmless why should it be disabled when set to false ? Agree that default is TRUE , but configuring false makes to disable it . We don't see any downside of enabling/sending CSNP always. Since It is light weight, only packet header exchange.

Advantage of enabling is always -syncing Database will be sooner if the network has some flooding issues as CSNP as the packet headers will be exchanged

Option to disable might lead to out-of-sync database.

Can this knob be removed from standard considering the downside of disable (enable =false) option allowing CSNP transmission by default

github-actions[bot] commented 6 months ago

This issue is stale because it has been open 180 days with no activity. If you wish to keep this issue active, please remove the stale label or add a comment, otherwise will be closed in 14 days.

sms-juniper commented 6 months ago

This issue is stale because it has been open 180 days with no activity. If you wish to keep this issue active, please remove the stale label or add a comment, otherwise will be closed in 14 days.

adding comment to remove stale

dplore commented 5 months ago

I can confirm that we are not using this inside google at the moment. Another useful piece of information you could provide @sms-juniper is if this feature is (or is not) implemented on implementations from juniper,cisco,arista,nokia or any others you can find (or not find) a public reference.

sms-juniper commented 5 months ago

As per standards CSNP are meant to be on broadcast link only.

http://standards.iso.org/ittf/PubliclyAvailableStandards/c030932_ISO_IEC_10589_2002(E).zip

Its up to venders to implemet this as proprietary for p2p links. Juniper has implemeted to send CSNP periodically on p2p link for fater convergence as mentioned in the issue description.

We feel its not a better idea to keep some non-standard [proprietary knob] in a vender neutral model like OpenConfig.