search

openconfig / public

Repository for publishing OpenConfig models, documentation, and other material for the community.
Apache License 2.0
876 stars 642 forks source link

openconfig-isis.yang: lsp-pacing-interval description is wrong #99

Open ghankins opened 6 years ago

ghankins commented 6 years ago

oc-ext:openconfig-version "0.3.3";

leaf lsp-pacing-interval {
  type uint64;
  units milliseconds;
  description
    "The interval interval in milliseconds between the
    detection of topology change and when the SPF algorithm runs.";
}
3alexb commented 6 years ago

ack. will change: leaf lsp-pacing-interval { type uint64; units milliseconds; description "The interval in milliseconds during which LSPs are sent from interface."; }

matt-arrcus commented 3 years ago

This description is still wrong in https://github.com/openconfig/public/blob/ed650bd969afc2eb5f66d60b86b62ffa6fd5fb8e/release/models/isis/openconfig-isis.yang#L824-L825

The pacing interval is not an SPF delay. It's a rate limit on the transmission of LSPs on a specific IS-IS interface.

Besides the redundant "interval", this appears to be a copy-and-paste from leaf spf-first-interval, whose behavior corresponds to this description.

github-actions[bot] commented 1 week ago

This issue is stale because it has been open 180 days with no activity. If you wish to keep this issue active, please remove the stale label or add a comment, otherwise will be closed in 14 days.